gh-138644: docs/c-api: Fix outdated PyInterpreterState doc about shared GIL #138650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the C API documentation still specified the state before https://peps.python.org/pep-0684/. Remove the obsolete note.
|
The following commit authors need to sign the Contributor License Agreement: |
bedevere-app
bot
added
awaiting review
docs
|
I can't sign the CLA at the moment. If it's required for doc PRs like this as well, I'll have to close it unmerged. |
| process state like available memory, open file descriptors and such. | ||
| .. versionchanged:: 3.12 | ||
| Each subinterpreter now :ref:`has its own GIL <per-interpreter-gil>`. |
There was a problem hiding this comment.
We should mention that this is still an optional feature. Legacy subinterpreters (Py_NewInterpreter) still share the GIL.
There was a problem hiding this comment.
I agree. Let's specify that it is configurable. Different interpreters can share gil or create one per interpreter.
All contributions require it :( Thanks a lot for the report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also tried to add a
versionchangedentry but don't have the tooling set up to build this locally so it's untested... If desired I can restrict to just removing the note (just 83ad926)📚 Documentation preview 📚: https://cpython-previews--138650.org.readthedocs.build/